Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35113 )
Change subject: mb/google/drallion: add dummy SPD file ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/arcada_cml/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... PS2, Line 17: SPD_SOURCES = empty_ddr4 # 0b00000 soldered down memory is not planned for arcada_cml and sarien_cml, do we really to update these 2 variants?
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/sarien_cml/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... PS2, Line 17: 0b00000 soldered down memory is not planned for arcada_cml and sarien_cml, do we really to update these 2 variants?