Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )
Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46091/9/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46091/9/src/mainboard/intel/adlrvp/... PS9, Line 22: BIT_2_0
BOARD_ID_MASK maybe?
we just need 3 bits here, BOARD_ID_MASK we already have https://review.coreboot.org/c/coreboot/+/46091/9/src/mainboard/intel/adlrvp/... which is bit 5:0