Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )
Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h
File src/acpi/sata.h:
https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
No strong feelings about the SPDX. But is the C++ style // comment necessary? […]
I'm fine with either style. This is how it is in the Linux kernel, so I copied that. If we'd prefer C style comments instead, that works for me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3
Gerrit-Change-Number: 36176
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Oct 2019 16:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment