Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30847 )
Change subject: mb/emulation/qemu-i440fx: remove mm file listing
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30847/7/src/mainboard/emulation/qemu-i440fx/...
File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/30847/7/src/mainboard/emulation/qemu-i440fx/...
PS7, Line 65: fw_cfg_read(&count, sizeof(count));
looks like be32_to_cpu(count) is missing
You were right
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie97ed3f0c98a5bb18a35ab0eaf8c4777a53e5779
Gerrit-Change-Number: 30847
Gerrit-PatchSet: 8
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Jan 2019 12:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment