Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37830 )
Change subject: vendorcode/intel/fsp/fsp2_0/tgl: Add FSP header files for Tigerlake
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37830/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37830/1//COMMIT_MSG@7
PS1, Line 7: Tigerlake
Done
Doesn't seem to be done yet. Maybe forgot to push the updated change? :D
https://review.coreboot.org/c/coreboot/+/37830/1//COMMIT_MSG@10
PS1, Line 10:
Tiger Lake FSP platform version 2457 will help to generate, isn't that enough?
These files are generated when building FSP. Since IntelFSP on Github does not have the Tiger Lake FSP yet, the headers need to be somewhere so that the platform code can build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52bb2e164cc89d3535fe67493686d1e8e064e31e
Gerrit-Change-Number: 37830
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 14:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment