Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37602 )
Change subject: mb/lenovo/t530: Switch to overridetree ......................................................................
Patch Set 9: Code-Review+1
(5 comments)
Um, I saw things.
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/d... File src/mainboard/lenovo/t530/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/d... PS9, Line 4: { 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 } This should be trimmed to size. Then, it's the same as w530
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/d... PS9, Line 46: 6 Cougar Point It's actually Panther Point (should be handled in another patch). Basically, look for boards selecting the C216 southbridge
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/d... PS9, Line 55: # Enable SATA ports 0 (HDD bay) & 1 (ODD bay) & 2 (mSATA) & 3 (eSATA) & 4 (dock) Meh, this comment is wrong as well
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/v... File src/mainboard/lenovo/t530/variants/w530/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/v... PS9, Line 3: register "gpu_dp_b_hotplug" = "0" : register "gpu_dp_c_hotplug" = "0" These are zero and can be dropped
https://review.coreboot.org/c/coreboot/+/37602/9/src/mainboard/lenovo/t530/v... PS9, Line 10: register "docking_supported" = "1" Shouldn't T530 also select this?