[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Enable RTD3 for SD card

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47377 )

Change subject: mb/google/volteer: Enable RTD3 for SD card
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47377/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/47377/2/src/mainboard/google/voltee... 
PS2, Line 451: # Enable GPIO is disabled in mainboard.c for RTS5261
Can this not be handled in devicetree using multiple entries each with its own probe property?

chip soc/intel/common/block/pcie/rtd3
    register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)"
    register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H3)"
    register "srcclk_pin" = "3"
    device generic 0 on
    	probe DB_SD SD_GL9755S
    end
end
chip soc/intel/common/block/pcie/rtd3
    register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H3)"
    register "srcclk_pin" = "3"
    register "is_external" = "1"
    device generic 1 on
    	probe DB_SD SD_RTS5261
    end
end