Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35377 )
Change subject: lib/fmap: Cache FMAP in cbmem
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35377/10/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/35377/10/src/lib/fmap.c@46
PS10, Line 46: if (region_device_sz(&cache->rdev))
this accesses cache->rdev (and inside, several more level of indirection) without checking if any of that is valid
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35377
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e01c573c3edfa34dbba5fe7604d4f6e18b584d5
Gerrit-Change-Number: 35377
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Fri, 20 Sep 2019 15:04:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment