HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v...
File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/1/src/mainboard/lenovo/x230/v...
PS1, Line 14: #include <southbridge/intel/bd82x6x/pch.h>
: #include <southbridge/intel/common/gpio.h>
southbridge/intel/bd82x6x/pch.h is used, while southbridge/intel/common/gpio.h can be excluded.
yes, <southbridge/intel/bd82x6x/pch.h> is used
sorry
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 May 2020 08:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment