Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, chris wang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 )
Change subject: amd/cezanne: Add telemetry setting to UPD
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/9a028f74_5d3d99b6
PS1, Line 73: uint32_t telemetry_vddcrvddfull_scale_current;
i'd add _mA to match picasso and have the unit right in the struct element name; same in line 75
++
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/c6ce5ae3_ef56664d
PS1, Line 106: 0x04C7
see my comment about the alignment on the fsp-side patch. […]
We have SO many unaligned fields. I think that we should either care about all of them, or not care about this one. If we care, we should really update the entire structure to be aligned(which is my preference).
The FSP build gives warnings about the unaligned PCDs, so we should be able to halt on that if someone adds an unaligned PCD in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e
Gerrit-Change-Number: 52733
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment