Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35077 )
Change subject: security/vboot: Decouple measured boot from verified boot ......................................................................
Patch Set 57:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35077/54/src/drivers/pc80/tpm/Makef... File src/drivers/pc80/tpm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35077/54/src/drivers/pc80/tpm/Makef... PS54, Line 5: bootblock-$(CONFIG_LPC_TPM) += tis.c
No longer necessary.
Done
https://review.coreboot.org/c/coreboot/+/35077/54/src/lib/bootblock.c File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35077/54/src/lib/bootblock.c@24 PS54, Line 24: #include <security/tpm/tspi/crtm.h>
No longer necessary.
Done
https://review.coreboot.org/c/coreboot/+/35077/55/src/security/tpm/tspi/crtm... File src/security/tpm/tspi/crtm.c:
https://review.coreboot.org/c/coreboot/+/35077/55/src/security/tpm/tspi/crtm... PS55, Line 129: else
else should follow close brace '}'
Done