Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/#/c/23135/23/src/superio/aspeed/ast2400/superio....
File src/superio/aspeed/ast2400/superio.c:
https://review.coreboot.org/#/c/23135/23/src/superio/aspeed/ast2400/superio....
PS23, Line 49: &ops
these should be replaced with NULL, since all LDNs use &ops passed to pnp_enable_devices below and no special per-LDN override is needed in the pnp_info struct
https://review.coreboot.org/#/c/23135/23/src/superio/aspeed/ast2400/superio....
PS23, Line 55: { &ops, AST2400_GPIO, PNP_IRQ0, },
the GPIO LDN doesn't have an IO region?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 23
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Sun, 12 May 2019 16:13:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
