Attention is currently required from: Nico Huber, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48236 )
Change subject: mb/emulation/qemu-q35: Account for TSEG
......................................................................
Patch Set 8: Code-Review+1
(4 comments)
File src/mainboard/emulation/qemu-i440fx/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/comment/091cd64e_24626424
PS8, Line 56: uintptr_t
size_t
https://review.coreboot.org/c/coreboot/+/48236/comment/bf9acc97_2fbeaf35
PS8, Line 57: smm_base
top ?
File src/mainboard/emulation/qemu-q35/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/comment/8e4d0bdd_75a00636
PS8, Line 25: esmramc
Should we check the enable bit?
https://review.coreboot.org/c/coreboot/+/48236/comment/d8d9e93a_7c09a1aa
PS8, Line 42: 0x%08lx
%p ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fd82a42d6602f1369bb3c69556c46f537542705
Gerrit-Change-Number: 48236
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 21 Jan 2021 12:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment