Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation
......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
You can run make gitconfig first before submit, that will introduce a script to check that.
Got it! Thank you very much.
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG@17
PS1, Line 17:
Can you add a Signed-off-by line? That is what triggered the verified -1.
added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31034
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia838818a76a7f638b24146f3eb48493a4091c9cb
Gerrit-Change-Number: 31034
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Jan 2019 04:08:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment