Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37994 )
Change subject: mb/google/peppy: Add ALS as ACPI device ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37994/2/src/mainboard/google/slippy... File src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37994/2/src/mainboard/google/slippy... PS2, Line 168: // GPIO51 (ball R5) is PIRQT: PIRQL_GSI + PIRQL - PIRQT = PIRQW_GSI : // 27 + 3 - 11 = 35 this comment doesn't make a ton of sense here without the resulting value used below and not hidden away in another file. I'd argue it belongs either in the onboard.h with the definition, or in that commit's message.
https://review.coreboot.org/c/coreboot/+/37994/2/src/mainboard/google/slippy... PS2, Line 179: Return (0xF) how does the OS (linux, windows) handle this in the case where no ALS is present?