[coreboot-gerrit] Change in coreboot[master]: fw_config: Convert fw_config to a 64-bit field

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45939 )

Change subject: fw_config: Convert fw_config to a 64-bit field
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45939/2/util/sconfig/main.c 
File util/sconfig/main.c:

https://review.coreboot.org/c/coreboot/+/45939/2/util/sconfig/main.c@406 
PS2, Line 406: 	/* Check that field is within 64 bits. */
do we need to limit field width to 32 bits?
what about fields spanning the 32 bit boundary?

https://review.coreboot.org/c/coreboot/+/45939/2/util/sconfig/main.c@554 
PS2, Line 554: (uint64_t)(option->value << (uint64_t)field->start_bit)
hmm... looks like you're casting to uint64_t after the bits are truncated:

(uint64_t)option->value << field->start_bit