Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: [WIP] soc/amd/common: Access ACPI MMIO via proper symbols ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/ac... PS4, Line 28:
Indent is off
Like gpio_100, no room for whitespace unless I realign them all. Immediate followup touches these lines so this eyesore goes away.
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/4/src/soc/amd/common/block/in... PS4, Line 42: Damn,
Or maybe use a minced oath like "Darn" or "Dang" which are not so charged?
Done