Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42874 )
Change subject: mb/google/kahlee: Do not enable SCI for H1_PCH_INT_ODL ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42874/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42874/4//COMMIT_MSG@7 PS4, Line 7: mb/google/kahlee: Do not enable SCI for H1_PCH_INT_ODL Yeah, I will update the aliases. I actually have a change to drop the alias from zork: https://review.coreboot.org/c/coreboot/+/42941. I can do the same for kahlee.
I associate PCH with Intel, google/kahlee is AMD.
Yeah, I suspect that the initial net-naming got copied over from another project and hence the _PCH_ name remained. It is fixed in zork.
And open-drain sounds irrelevant for input pins so _ODL was just dropped at some places from the names it seems.
Actually, the signal is open-drain coming into the FCH/SoC because of the way the signal is routed in hardware.