Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: drivers: Replace set_vbe_mode_info_valid
......................................................................
Patch Set 29:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39004/28//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39004/28//COMMIT_MSG@24
PS28, Line 24: The platforms doesn't read an EDID anyway.
Some do, though.
Right, I squashed two commits, so this is no longer true.
https://review.coreboot.org/c/coreboot/+/39004/28//COMMIT_MSG@24
PS28, Line 24: doesn't
don't
Done
https://review.coreboot.org/c/coreboot/+/39004/28/src/drivers/aspeed/common/...
File src/drivers/aspeed/common/ast_mode_corebootfb.c:
https://review.coreboot.org/c/coreboot/+/39004/28/src/drivers/aspeed/common/...
PS28, Line 227: edid.framebuffer_bits_per_pixel);
Why not use _from_edid() here?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95d1d62385a201c68c6c2527c023ad2292a235c5
Gerrit-Change-Number: 39004
Gerrit-PatchSet: 29
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Nov 2020 14:17:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment