[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/r500: Add mainboard

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28644 )

Change subject: mb/lenovo/r500: Add mainboard
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig 
File src/mainboard/lenovo/t400/Kconfig:

https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig@13 
PS7, Line 13: 	select BOARD_ROMSIZE_KB_8192
            : 	select BOARD_ROMSIZE_KB_4096 if BOARD_LENOVO_R500
> Doesn't this conflict?

It iterates from small to big in mainboard/Kconfig so it works... Still better to make it more explicit.