Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58767 )
Change subject: driver/intel/mipi_camera: Add support for _DSC field ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58767/comment/a6db56ec_7e757a61 PS5, Line 27: TEST:
Please use TEST=
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/58767/comment/ff7ddeba_020e1292 PS6, Line 23: More details can be found here https://lkml.org/lkml/2021/10/25/397
also I believe this is expected to be added to ACPI 6. […]
I am waiting for sakari to comment on that, I am not sure which rev it will be included
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/58767/comment/e0579a3d_806c12dd PS6, Line 850: (
nit: space after `if`
Done
https://review.coreboot.org/c/coreboot/+/58767/comment/1ffd754c_f0f656b0 PS6, Line 852: 0x4
`ACPI_DEVICE_SLEEP_D3_COLD` […]
I think you meant defining this in chip.h ? I have update the patch, is this what you meant ?
File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/58767/comment/aa23dd4b_b506c192 PS5, Line 260: acpi_dsc;
If the kernel doesn't check for its existence, I don't see how it could be a problem to include it.
I think subrata meant to remove the if condition in the camera.c file and have it defined in all devices, CAM, NVM and VCM earlier implementation I had done was more like replacing i2c-low-power-probe and adding only D3cold off but now I have changed it.