Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44948 )
Change subject: mb/google/volteer/variants/volteer: route GPP_F14 via APIC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44948/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/44948/1/src/mainboard/google/voltee...
PS1, Line 128: PAD_CFG_GPI_APIC(GPP_F14, NONE, PLTRST, LEVEL, INVERT),
If there apic redirection entry is active low there's no need to invert because the inversion for th […]
thanks for the explanation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie262ceeaea1c07bcc99e1545f5eb99e0d0dee905
Gerrit-Change-Number: 44948
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Levin
levinale@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 31 Aug 2020 22:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Levin
levinale@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment