17 Dec
2019
17 Dec
'19
8:40 p.m.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support ......................................................................
Patch Set 14:
(1 comment)
Can you address my question re the comment?
https://review.coreboot.org/c/coreboot/+/33985/14/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/33985/14/src/include/cpu/x86/smm.h@... PS14, Line 515: /* useg to get the mseg address into smm for setup */ This one confuses me. Is the word supposed to be "used" instead of "useg"?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33985
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b8e68b2928aefc7996b6a9560c52f71c7c0e1d0
Gerrit-Change-Number: 33985
Gerrit-PatchSet: 14
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Tue, 17 Dec 2019 20:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment