HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
Why did you add a space?
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Please mention this in the commit message
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
mistake on rebase ... […]
Done