Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31744 )
Change subject: x86/car: Fix incorrect config usage
......................................................................
Patch Set 1: Code-Review+1
If I read this correctly, FSP1_0 platforms called do_car_migrate_variables() when it should not have. However, as the call is made after FSP1_0 already has torn CAR down, car_migrated variable would return non-zero on line 127.
The code on FSP1_0 CAR migration was originally tested on intel/minnowmax.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31744
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74e0ed4d04471ee521ff5c69a74a6f4c949e5847
Gerrit-Change-Number: 31744
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Mar 2019 03:51:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment