Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )
Change subject: soc/amd/picasso: Add generic SMU service request ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c File src/soc/amd/picasso/smu.c:
https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@2... PS1, Line 21: smu_poll_response Can you make this return the response value..
https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@4... PS1, Line 47: The PPR says: 1. Wait until the Response register is non-zero. 2. Write zero (0) to the Response register.
Do we need to add the first wait?
https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@5... PS1, Line 56: Check the response value:
- If the Response register contains OK, then the SMU has finished processing the message.