Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52643 )
Change subject: soc/amd/common/acp: Move Audio Co-processor driver to common
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/acp.h:
https://review.coreboot.org/c/coreboot/+/52643/comment/eb20e542_923ddc97
PS3, Line 22: bool acp_i2s_use_external_48mhz_osc;
not happy about this, but if this gets fixed soon, i won't complain too much ;p
would be good if you create a ticket for this, so we don't forget about it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91470ff68d1c183df9a2927d71b03371b535186a
Gerrit-Change-Number: 52643
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Thu, 29 Apr 2021 22:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment