Attention is currently required from: Evan Green. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64002
to look at the new patch set (#2).
Change subject: soc/intel: Return ACPI_S4 as previous sleep state ......................................................................
soc/intel: Return ACPI_S4 as previous sleep state
pmc_prev_sleep_state() isn't handling the case where acpi_sleep_from_pm1() returns ACPI_S4. Pass that value along so it can get set as a prev_sleep_state. Without this, consumers see prev_sleep_state as 0 and always treat resume as a cold boot. With this, consumers can correctly do behavior specific to S4 resume, like skipping the disconnect IPC command to the PMC on Alderlake systems.
BUG=b:230031158 TEST=Resume from S4 on Primus4es
Signed-off-by: Evan Green evgreen@chromium.org Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689 --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/64002/2