Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/skl: Use devtree options to set primary GPU ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/32044/4/src/soc/intel/skylake/chip.h File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/#/c/32044/4/src/soc/intel/skylake/chip.h@314 PS4, Line 314: /* I think it's better to use enum here.
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst... File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst... PS1, Line 280: m_cfg->InternalGfx = 1;
set internalGfx to enabled if PCI 0:2.0 is present and enabled in devicetree.
Ok. Done
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst... PS1, Line 282: PrimaryDisplay
I don't see any skylake/kabylake boards currently setting this in the device tree. […]
I set PrimaryDisplay devicetree.cb for all skl/kbl board.
patch : Change-Id: Ibed05fc9171e2bd73654f0da6273a8534746913d
For h110m - set "Display_PEG" (1) others - set "Display_Auto" (3)
https://review.coreboot.org/#/c/32044/1/src/soc/intel/skylake/romstage/romst... PS1, Line 285: m_t_cfg->SkipExtGfxScan = config->SkipExtGfxScan;
SkipExtGfxScan should only be set to 1 on all boards that only use IGD (like chromebooks).
devicetree.cb for all boards with a skl / kbl processor already contain this option.