Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )
Change subject: ec/lenovo/h8: Add a config to indicate whether dock init is needed
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig
File src/ec/lenovo/h8/Kconfig:
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig@47
PS1, Line 47: H8_NEED_DOCK_INIT
Maybe it's not worth to overcomplicate things. […]
Done
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig@48
PS1, Line 48: "Dock init during boot is necessary"
This is a property of the board. Please don't make it user selectable.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5737406d1f6cb6e91b2e2fa349a206a3dba988d1
Gerrit-Change-Number: 36385
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Oct 2019 17:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment