Attention is currently required from: Meera Ravindranath, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56168 )
Change subject: drivers/intel/gma: Define structure for Opregion version
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/intel/gma/opregion.h:
https://review.coreboot.org/c/coreboot/+/56168/comment/45f942fe_bd70bebf
PS3, Line 21:
One less tab is required.
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/56168/comment/f2c6c59c_87e5cdc3
PS3, Line 357: opregion->header.version = IGD_OPREGION_VERSION << 24;
This is dropped without anything setting `over` fields.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9f2df186002a4e38caa910f867bce0b97ac2b
Gerrit-Change-Number: 56168
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 09 Jul 2021 07:49:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment