Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: add function to detect defeatured SKU ......................................................................
Patch Set 1:
(2 comments)
if you have some better name than defeatured, i'm all ears
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 212: bool soc_is_defeatured_sku(void)
Which features are missing? If it's just xhci1? We could change to something like soc_has_xhci1 and […]
less PCIe lanes, no second XHCI controller, less USB3 ports, no 4th display port, only 2C/4T and maybe something more
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 214: SILICON_RV2
Could be reduced to 'soc_is_raven2() || soc_is_dali()'
it would be equivalent, but i'm not sure if i should use the functions here that are mostly there for convenience when used in the soc/mainboard code. If we ignore the whole CPUID business that i only kept to still guess the types correctly in maybe 90% of the cases when the HOB is missing, this would be is_rv2_silicon() || is_mystery_silicon(). not sure if I should just rip the whole CPUID stuff out of the detection logic