[coreboot-gerrit] Change in coreboot[master]: bootblock: Provide some common prototypes

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37429 )

Change subject: bootblock: Provide some common prototypes
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37429/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37429/1//COMMIT_MSG@10 
PS1, Line 10: southbridge is not specific to intel at all.
> For AMD we could reuse bootblock_early_southbridge_init() name, not sure if we need the rest. […]

I think stuff should go in lib/bootblock if it's "all but x86" code (e.g. decompressor support), but it can go in arch/x86 if it's x86-only code.

For the pc80/cmos stuff, I agree, I'd prefer to see that moved somewhere else too (we could create a bootblock_arch_early_init() or something...).