Attention is currently required from: Robert Zieba, Tarun Tuli, Subrata Banik, Kapil Porwal, Nick Vaccaro, Prashant Malani, Boris Mittelberg.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72370 )
Change subject: ec/google/chromeec: Add handles for ori, usb role switch
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/72370/comment/5b15dff0_5a139011
PS3, Line 195: .orientation_switch = config->ori_conn[i],
: .usb_role_switch = config->usb_role_conn[i],
Thanks for confirming. […]
could you add the skyrim case as the next patch so we have some insight
into what's coming up? i didn't see anything interesting USB related
in the existing skyrim device tree.
sounds like part of the problem is that you can't disable
`orientation_switch` or `usb_role_switch` by just explicitly setting
them to NULL in the device tree since that's indistinguishable from not
being present. would it make sense to introduce explicit
`no_orientation_switch`, `no_usb_role_switch` parameters to the
device tree?
`fill_ssdt_typec_device()` will have to check for those.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f5dff865db765693cde63a23173b215b20b6c02
Gerrit-Change-Number: 72370
Gerrit-PatchSet: 4
Gerrit-Owner: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 31 Jan 2023 23:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Prashant Malani
pmalani@chromium.org
Gerrit-MessageType: comment