Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46734 )
Change subject: Revert "broadwell: Switch to using common ACPI _SWS code"
......................................................................
Patch Set 9: Code-Review+2
Patch Set 9:
Patch Set 9:
What about making haswell use the common code instead of reverting this?
Neither Haswell nor Broadwell are SoCs. I can switch to using common code again once there's only one copy of this code.
Who said they are? ;) Yeah, would be great. That whole wake source stuff could go to southbridge/common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29c4ad9174ab84c7e9111daa0491ede9e1d639b4
Gerrit-Change-Number: 46734
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 10:27:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment