[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu1/mainboard.c: fix building order and resource alloca...

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42512 )

Change subject: mb/pcengines/apu1/mainboard.c: fix building order and resource allocation
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42512/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42512/2//COMMIT_MSG@11 
PS2, Line 11: resource allocation and/or enumeration.
Nothing wrong with the resource allocation and enumeration. Please mention the #pragma Porting.h I mentioned earlier.

What happened is mainboard.c file used different binary layout of 'struct device' because of the attribute((packed)) and the reference dev->bus->secondary landed at wrong memory address.