Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38422 )
Change subject: cbfs: Hook up to new CBFS implmentation
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38422/4/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38422/4/src/lib/cbfs.c@62
PS4, Line 62: return -1;
Is this to handle that weird case that Ron added in https://review.coreboot.org/26279 ? I don't think that should have landed in practice. Comment for this function still indicates:
/* Locate file by name and optional type. Return 0 on success. < 0 on error. */
I think we should nuke this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d112d1239475920de2d872dac179c245275038d
Gerrit-Change-Number: 38422
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jan 2020 16:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment