Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43061 )
Change subject: soc/intel/tigerlake: Update Tiger Lake SA IDs ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43061/12/src/include/device/pci_ids... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/43061/12/src/include/device/pci_ids... PS12, Line 3524: #define PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2 0x9A14 : #define PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2 0x9A04 : #define PCI_DEVICE_ID_INTEL_TGL_ID_Y_4_2 0x9A12 : #define PCI_DEVICE_ID_INTEL_TGL_ID_Y_2_2 0x9A02 might as well apply _2_4 before _4_4 ordering here as well for consistency.
https://review.coreboot.org/c/coreboot/+/43061/12/src/soc/intel/tigerlake/bo... File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/43061/12/src/soc/intel/tigerlake/bo... PS12, Line 35: { PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2, "Tigerlake-U-4-2" }, : { PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2, "Tigerlake-U-2-2" }, : { PCI_DEVICE_ID_INTEL_TGL_ID_Y_4_2, "Tigerlake-Y-4-2" }, : { PCI_DEVICE_ID_INTEL_TGL_ID_Y_2_2, "Tigerlake-Y-2-2" }, also reorder -2-2 before -4-2 here.
https://review.coreboot.org/c/coreboot/+/43061/12/src/soc/intel/tigerlake/sy... File src/soc/intel/tigerlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/43061/12/src/soc/intel/tigerlake/sy... PS12, Line 81: case PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2: : soc_config = &config->power_limits_config[POWER_LIMITS_U_4_CORE]; : break; : case PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2: : soc_config = &config->power_limits_config[POWER_LIMITS_U_2_CORE]; : break; _2_2 before _4_2 here as well.