Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: console: Unify overriding console log level with get_option() ......................................................................
Patch Set 11: Code-Review-1
(3 comments)
I think that this has a couple of issues, but it headed the right direction.
The commit should be split.
This probably breaks arm and other xip platforms and needs to be checked.
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG@9 PS11, Line 9: Add config MAINBOARD_OPTIONS and remove CONSOLE_OVERRIDE_LOGLEVEL, : it lets mainboard provide overridden function for getting configuration : values via get_option(). Currently it's only used for overriding : console log level. Add a description of how this works in the Documentation/ since it is a framework for going forward.
This comment could be reworded with that in mind
https://review.coreboot.org/c/coreboot/+/45134/11//COMMIT_MSG@17 PS11, Line 17: performance. This is a nice cleanup and could be a separate commit.
https://review.coreboot.org/c/coreboot/+/45134/11/src/console/init.c File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/45134/11/src/console/init.c@30 PS11, Line 30: The following will break on !ENV_STAGE_HAS_DATA_SECTION where the variable can't be set (ARM and other XIP with no CAR or RAM). I think you still need (CONSOLE_LEVEL_CONST)