Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/mainboard/dedede: support touchpad for Boten ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/43175/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43175/2//COMMIT_MSG@7 PS2, Line 7: support touchpad for Boten Update device tree for Boten
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 41: "USB2_PORT_MID(OC_SKIP)" # Type-C Port C1 For Boten project, there is no C port in the DB. close it.
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 50: "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C1 No C port in the DB.
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 75: register "desc" = ""Right Type-C Port"" please close it
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 114: register "desc" = ""Right Type-C Port"" please close it
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 161: device pci 15.2 on end # I2C 2 Please add touch screen description.
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 169: device pci 19.1 off end # I2C 5 Please enable this port since for P sensor