Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40229 )
Change subject: sb/intel/bd82x6x/sata: Don't hard-code values ......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/40229/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40229/1//COMMIT_MSG@7 PS1, Line 7: sb/intel/bd82x6x/sata: Don't write RO register
Ooops, now that I see it again, it's actually not trying to write the […]
Done
https://review.coreboot.org/c/coreboot/+/40229/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/sata.c:
https://review.coreboot.org/c/coreboot/+/40229/1/src/southbridge/intel/bd82x... PS1, Line 63: pci_write_config8(dev, INTR_LN, 0x0a);
Please also remove this and the definition of INTR_LN in `pch.h`.
Done