[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure RP setting

[Alex Levin (Code Review)]

Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40262 )

Change subject: soc/intel/tigerlake: Configure RP setting
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40262/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40262/3//COMMIT_MSG@9 
PS3, Line 9: Configure RP LTR and AER
Would suggest a rephrase in the spirit of:

Adding LTR and AER configuration to the root ports config

https://review.coreboot.org/c/coreboot/+/40262/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/40262/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 128: 		params->PcieRpLtrEnable[i] = !config->PcieRpLtrDisable[i];
why is the opposite of the config setting? why not keep it uniform? i.e. use LTR enable for both or LTR disable for both?