Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50478 )
Change subject: sb/intel/lynxpoint: Do not mask out TCO status bits
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/lynxpoint/pmutil.c:
https://review.coreboot.org/c/coreboot/+/50478/comment/7283b08b_f337d838
PS1, Line 314: tco_sts
Yeah, but it's not really an issue. We only handle BIOSWR_STS and TIMEOUT.
I checked the datasheet, and the TCOx_STS/TCOx_EN bits don't match at all. The masking that the code originally did makes no sense.
Plus, we don't enable TCO SMI generation right now. Currently, this change has no effect.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49abb5a4a99e943e57e0aaa6f06ff63bdf957cd3
Gerrit-Change-Number: 50478
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 14:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment