Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68167 )
Change subject: mb/google/brya: enable PCIe RP12 for lisbon eMMC support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/lisbon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68167/comment/770e6b27_5a7fcb28
PS1, Line 205: register "pch_pcie_rp[PCH_RP(12)]" = "{
I think register settings need to be enclosed in a chip descriptor like lines 196-201.
Hi Nick,
I'm afraid that rtd3 does not have the "pch_pcie_rp" member in the structure, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8ca9cf845156ac761556d0eb49edb65894c001
Gerrit-Change-Number: 68167
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 02:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment