Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47431 )
Change subject: soc/intel/common: Generate the CSE RW metadata and add to FW_MAIN_A/B
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47431/10/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/47431/10/src/soc/intel/common/block...
PS10, Line 45: SOC_INTEL_CSE_RW_METADATA_CBFS_NAME
This should also be defined only if SOC_INTEL_CSE_RW_UPDATE is defined.
https://review.coreboot.org/c/coreboot/+/47431/10/src/soc/intel/common/block...
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/47431/10/src/soc/intel/common/block...
PS10, Line 46: #define SHA256_DIGEST_SIZE 32
Not required any more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I412581400a9606fa17cf4398faffda923f07b320
Gerrit-Change-Number: 47431
Gerrit-PatchSet: 10
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 14 Nov 2020 00:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment