Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33160 )
Change subject: qcs405: Add board_id entry in the interface table ......................................................................
Patch Set 4:
Patch Set 1:
What is this used for? QcLib should not have direct knowledge of coreboot board revisions, it should be completely board-independent. If there are board-specific differences that it needs to take into account, the interface table should offer options for specific features, and coreboot should select them based on the board.
Discussed with Julius: for stuff where we need to differentiate like that, please look into creating feature flags that are exported to the blob (e.g. "use_int_buck") and set them from coreboot rather than hiding the decision made in qclib