HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for common enclosures
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31206/7/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/31206/7/src/arch/x86/acpi.c@1072
PS7, Line 1072: CONFIG_SYSTEM_TYPE_TABLET
we have "PM_TABLET", why don't you use it ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148ec2329a1dd38ad55c60ba277a514c66376fcc
Gerrit-Change-Number: 31206
Gerrit-PatchSet: 7
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment