Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47235 )
Change subject: drivers/i2c/rx6110sa: Add basic ACPI support ......................................................................
Patch Set 6: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/47235/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47235/5//COMMIT_MSG@11 PS5, Line 11:
If you could add it, that’d be great for a TEST= line. If not, it’s only a nit.
Done
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... File src/drivers/i2c/rx6110sa/rx6110sa.c:
https://review.coreboot.org/c/coreboot/+/47235/3/src/drivers/i2c/rx6110sa/rx... PS3, Line 180: .speed = config->bus_speed ? : I2C_SPEED_FAST,
Using an enum is a good idea, too
Done
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... File src/drivers/i2c/rx6110sa/rx6110sa.c:
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... PS5, Line 176: !dev->enabled
Oh, I was not aware of this change, thank you. […]
Done
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... PS5, Line 185: printk(BIOS_WARNING, "%s: Unsupported bus speed in devicetree!\n",
I had that in the first place but the line got really long. […]
Done