Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51711 )
Change subject: soc/amd/cezanne: select HAVE_EM100_SUPPORT ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/51711/comment/c3a5e7b2_e8df97af PS1, Line 25: HAVE_EM100_SUPPORT
Can we remove fch_spi_config_em100_modes? The PSP already sets up the SPI registers via EFS. […]
i'd prefer to write the registers in coreboot and not rely on psp/abl doing the expected thing, since it's not always completely clear if it really did the thing that it was supposed to do. i'm ok with looking into changing the behavior after the board bringups, but i don't expect that to be really necessary. this patch only makes the kconfig option visible and aligns cezanne with picasso. the values that the spi setup function for the em100 mode uses is basically the safe default and if the boot is half a second slower due to that, it's still no issue during development imho. i don't think that em100 are or should be used for the boot time measurements