build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38542 )
Change subject: sc7180: QSIP SPI NOR addressing mode ......................................................................
Patch Set 8:
(9 comments)
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 504: if (reg8 & 0x1 ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 504: if (reg8 & 0x1 ) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 505: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Falling back to 3 byte addressing mode\n", reg8); 'adressing' may be misspelled - perhaps 'addressing'?
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 505: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Falling back to 3 byte addressing mode\n", reg8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 510: if (reg8 & 0x1 ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 511: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Exiting 4 byte mode not working . Looping here\n ", reg8); 'adressing' may be misspelled - perhaps 'addressing'?
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 511: printk(BIOS_WARNING, "4 byte adressing mode set:%02x\n. Exiting 4 byte mode not working . Looping here\n ", reg8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 512: while(1); space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/38542/8/src/drivers/spi/spi_flash.c... PS8, Line 512: while(1); trailing statements should be on next line